Download File Button and Recaptcha Missing - 6.4.7

[d33j4y2]

Hello! I recently updated Download mod from 6.4.5 to 6.4.7 but as of updating to 6.4.6, I noticed that the download file button is missing when you try to download any file on my site! I checked the settings and nothing was changed to cause this issue! I also noticed that the recaptcha will not show either when I set that setting in acp for the download mod!! I had updated to 6.4.7 but still have the same problem.. any ideas on how to fix this???

[oxpus]

Hello,

do you have dropped the forum cache and the caches from the style templates?

[d33j4y2]

I have narrowed it down to being something to do with this file ==> root/dl_mod/classes/class_dlmod.php

When I uploaded this same exact file from the Download Mod 6.4.5 version root files.. the download button and recaptcha were showing perfect but it doesnt show when i re-upload back this same file from the Download Mod 6.4.7 version root files!!

I went through all the settings in ACP for this mod, purged the Cache, refreshed the Templates, Themes, and Imagesets and everything else you could think of!! Everything worked fine up until I updated the Download Mod to the 6.4.6 version!!! You mustve changed some of the coding in this particular file perhaps!?!

[oxpus]

Yes, there are changes in this file, but nothing about the captcha.
But sorry, I myself have not a recaptcha account to check this...

[d33j4y2]

Im not at all worried about the recaptcha part of it as I dont use it anymore but I mentioned it because that too was not showing when I checked it!! Only thing Im worried about is the download button not showing which is due to something in that file..

[d33j4y2]

Hi oxpus! Ok, I narrowed it down to the code in "class_dlmod.php" that was causing the download button as well as the visual conformation(reCaptcha in my case) to not show when trying to download a file.

I had to add the "$_SERVER" back into the "public function dlmod()" from the changed code:

Code: Alles auswählen

global $db, $auth, $user, $config, $dl_cache;

I added $_SERVER back into here:

Code: Alles auswählen

global $db, $auth, $user, $config, $_SERVER, $dl_cache;

And had to change the following:

Code: Alles auswählen

$this->user_client = $user->data['session_browser'];

Back to:

Code: Alles auswählen

$this->user_client = strtolower($_SERVER['HTTP_USER_AGENT']);

The rest of the code in "class_dlmod.php" from the 6.4.7 update was untouched and I had re-uploaded the changed file back to my server and the visual confirmation and download button were once again showing!! Any idea why this wasnt working with the $_SERVER idea removed in the 6.4.7 updates!?!

[oxpus]

Stop!!

Please don't turn this code back to $_SERVER because you risk a security leak!!
To get back the download button open the ACP module "Banlist" of the mod and look about an entry with "n/a" in the field "Browser".
Drop this entry and the download button will be back.

[d33j4y2]

Ah yep I did as you said, changed the code back to the original session browser, deleted that entry in Banlist and the download button was there!!! Thanks for the heads up Oxpus!! Its all a learning process for me lol!! Good job with the updates!!

[oxpus]

Good job with the updates

Thanks.
And I hope you have fun with the mod after this little excursion.