Suggestion for Download Mod

Support zu den Modifikationen (MODs) von Entwickler OXPUS für das phpBB 3.0.x
Antworten
Pico
Beiträge: 26
Registriert: Do 30. Dez 2010, 11:53

Suggestion for Download Mod

Beitrag von Pico »

Hi,
I have a some suggestion for Download Mod (again :) )

First, in class_dlmod.php I will changed

Code: Alles auswählen

if ((($config['dl_overall_traffic'] - $config['dl_remain_traffic'] <= 0) || ($index[$cat_id]['cat_traffic'] && ($index[$cat_id]['cat_traffic'] - $index[$cat_id]['cat_traffic_use'] <= 0))) && !$config['dl_traffic_off'])
to

Code: Alles auswählen

if ((($config['dl_overall_traffic'] - $config['dl_remain_traffic'] <= 0) || ($index[$cat_id]['cat_traffic'] && ($index[$cat_id]['cat_traffic'] - $index[$cat_id]['cat_traffic_use'] <= 0)) || ($this->dl_file[$df_id]['file_size'] > $config['dl_overall_traffic'] - $config['dl_remain_traffic'])) && !$config['dl_traffic_off'])
Well, adding ($this->dl_file[$df_id]['file_size'] > $config['dl_overall_traffic'] - $config['dl_remain_traffic']) will display blue icon when there is not enough transfer to download specified file :) Now if there is not enough transfer it display other icon (yellow) and user is redirect do download detail.

Second, a little change for the forbidden extension. It would be nice to have an option to choose between disallowed and allowed extension :) maybe some user prefer to specify which extension ought to be allowed.
Benutzeravatar
oxpus
Chief handy-man
Beiträge: 2719
Registriert: Do 13. Dez 2007, 23:06
Wohnort: Irgendwo im I-Net
Kontaktdaten:

Re: Suggestion for Download Mod

Beitrag von oxpus »

The blue icon will only be used if the Traffic is exceeded for overall without any Traffic remaining.
So it should sign only the same as the footer will shown, too.

And the extensions: The Mod shield be able to host all file types, expected some types the Admin will expect.

So thanks for your suggestions, but the mod will not be changed for them.
But you can feel free to code an add-on...
Karsten Ude
Kein Support per Messenger, Email oder PN! Unaufgeforderte Nachrichten werden ignoriert!
No support per Messenger, Email or PM. Each unasked message will be ignored!
Pico
Beiträge: 26
Registriert: Do 30. Dez 2010, 11:53

Re: Suggestion for Download Mod

Beitrag von Pico »

Ok. I will look at 2. suggestion, but check first one.

It is a annoying when there is not enought transfer (in current month) and the file has still yellow icon but its file size is to big to download it.
There are to seperate description of blue icon (category and file) so why not add this code?

EDIT:
Example: there is only 2mb transfer, the file size is 10mb and it still has yellow icon, but in the fact it is not possible to download it.
Antworten