Notes v3.0.4

Support für Extensions für phpBB 3.1.x von Entwickler OXPUS
puchahawa
Beiträge: 16
Registriert: Do 9. Jun 2016, 23:08

Re: Notes v3.0.4

Beitrag von puchahawa » So 12. Jun 2016, 20:03

Correction: This is the page source of the v3.0.5 notes that I shared above.

Code: Alles auswählen

	<!DOCTYPE html>
<html dir="ltr" lang="en-gb">
<head>

<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1" />

<title>Nest Test - Notes</title>



<!--
	phpBB style name: aero
	Based on style:   prosilver (this is the default phpBB3 style)
	Original author:  Tom Beddard ( http://www.subBlue.com/ )
	Modified by: John Olson ( https://www.phpbb.com/community/viewtopic.php?f=476&t=2269886 )
-->

<link href="./../../styles/aero%20black/theme/stylesheet.css?assets_version=185" rel="stylesheet">
<link href="./../../styles/aero%20black/theme/en/stylesheet.css?assets_version=185" rel="stylesheet">
<link href="./../../styles/aero%20black/theme/responsive.css?assets_version=185" rel="stylesheet" media="all and (max-width: 700px)">



<!--[if lte IE 9]>
	<link href="./../../styles/aero%20black/theme/tweaks.css?assets_version=185" rel="stylesheet">
<![endif]-->

	<script type="text/javascript">
// <![CDATA[
	function switchProfiles() {
		var pss_cont = $('#page-body');
		var pss_btn = $('#profile-switcher');
		var pss_url = pss_btn.attr('href');
		var pss_left = pss_cont.hasClass('leftsided');

		phpbb.addAjaxCallback('pss', function(res) {
			if (res.success) {
				if(pss_left) {
					pss_cont.removeClass('leftsided');
					pss_btn.parent('li').attr('class', 'small-icon icon-pss-left');
					pss_btn.html('Postprofile on the left');
					pss_url = pss_url.substring(0, pss_url.length - 1) + '1';
				} else {
					pss_cont.addClass('leftsided');
					pss_btn.parent('li').attr('class', 'small-icon icon-pss-right');
					pss_btn.html('Postprofile on the right');
					pss_url = pss_url.substring(0, pss_url.length - 1) + '0';
				}
				pss_btn.attr('href', pss_url);
			}
		});
	}
// ]]>
</script>


<link href="./../../ext/abdev/qte/styles/prosilver/theme/qte.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />
<link href="./../../ext/hifikabin/navbarsearch/styles/prosilver/theme/navbarsearch.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />
<link href="./../../ext/phpbb/boardannouncements/styles/aero/theme/boardannouncements.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />
<link href="./../../ext/sniper/smiliesigns/styles/all/theme/smiliesigns.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />
<link href="./../../ext/tatiana5/profileSideSwitcher/styles/prosilver/theme/profile_side_switcher.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />
<link href="./../../ext/tatiana5/profileSideSwitcher/styles/prosilver/theme/en/profile_side_switcher.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />
<link href="./../../ext/vse/abbc3/styles/all/theme/abbc3.min.css?assets_version=185" rel="stylesheet" type="text/css" media="screen" />


<!-- Shinnanigans in headerbar styling -->
<style>
.headerbar {
   background-image: url("./../..//images/shinnanigans.png");
}

/** remove the logo and increase the height of the headerbar **/
.imageset.site_logo {
    background-image: none;
    padding-left: 0;
    padding-top: 205px;
}
</style>
</head>
<body id="phpbb" class="nojs notouch section-app/notes/ ltr ">


<div id="wrap">
	<a id="top" class="anchor" accesskey="t"></a>
	<div id="page-header">
		<div class="custombg"><div class="customborder">
		<div class="headerbg">
		<div class="headerbar" role="banner">
			<div class="inner">

			<div id="site-description">
				<a id="logo" class="logo" href="./../../index.php" title="Board index"><span class="imageset site_logo"></span></a>
				<h1>Nest Test</h1>
				<p></p>
				<p class="skiplink"><a href="#start_here">Skip to content</a></p>
			</div>
			

			
			</div>
		</div>
		</div>
		</div></div>

				
		<div class="custombg"><div class="customborder">
<div class="navbar" role="navigation">
	<div class="inner">

	<ul id="nav-main" class="linklist bulletin" role="menubar">

		<li id="quick-links" class="small-icon responsive-menu dropdown-container hidden" data-skip-responsive="true">
			<a href="#" class="responsive-menu-link dropdown-trigger">Quick links</a>
			<div class="dropdown hidden">
				<div class="pointer"><div class="pointer-inner"></div></div>
				<ul class="dropdown-contents" role="menu">
					
					
											<li class="separator"></li>
						<li class="small-icon icon-members"><a href="./../../memberlist.php" role="menuitem">Members</a></li>						<li class="small-icon icon-team"><a href="./../../memberlist.php?mode=team" role="menuitem">The team</a></li>										<li class="separator"></li>

									</ul>
			</div>
		</li>

				<li class="small-icon icon-faq" data-last-responsive="true"><a href="./../../faq.php" rel="help" title="Frequently Asked Questions" role="menuitem">FAQ</a></li>
		<li class="small-icon icon-bump"><a href="/phpbb12/app.php/notes/?mem_drop=1&mem_time=1465757940">Notes</a></li>		<li class="small-icon icon-acp" data-last-responsive="true"><a href="./../../adm/index.php?sid=5e4c7b0b3c7f7ad9554b7b294b6f1d32" title="Administration Control Panel" role="menuitem">ACP</a></li>		
					<li id="username_logged_in" class="rightside  no-bulletin" data-skip-responsive="true">
						<div class="header-profile dropdown-container">
				<a href="./../../ucp.php" class="header-avatar dropdown-trigger"><img class="avatar" src="./../../download/file.php?avatar=2899_1343850828.jpeg" width="117" height="175" alt="User avatar" /> <span style="color: #0000CC;" class="username-coloured">Randy</span></a>
				<div class="dropdown hidden">
					<div class="pointer"><div class="pointer-inner"></div></div>
					<ul class="dropdown-contents" role="menu">
							
							
						<li class="small-icon icon-ucp"><a href="./../../ucp.php" title="User Control Panel" role="menuitem">User Control Panel</a></li>
						<li class="small-icon icon-profile"><a href="./../../memberlist.php?mode=viewprofile&u=2899" title="Profile" role="menuitem">Profile</a></li>
	
							
						<li class="separator"></li>
						<li class="small-icon icon-logout"><a href="./../../ucp.php?mode=logout&sid=5e4c7b0b3c7f7ad9554b7b294b6f1d32" title="Logout" accesskey="x" role="menuitem">Logout</a></li>
					</ul>
				</div>
			</div>
					</li>
					<li class="small-icon icon-pm rightside" data-skip-responsive="true">
				<a href="./../../ucp.php?i=pm&folder=inbox" role="menuitem"><span>Private messages [</span><strong>0</strong><span>]</span></a>
			</li>
							<li class="small-icon icon-notification dropdown-container dropdown-right rightside" data-skip-responsive="true">
				<a href="./../../ucp.php?i=ucp_notifications" id="notification_list_button" class="dropdown-trigger"><span>Notifications [</span><strong>0</strong><span>]</span></a>
				<div id="notification_list" class="dropdown dropdown-extended notification_list">
	<div class="pointer"><div class="pointer-inner"></div></div>
	<div class="dropdown-contents">
		<div class="header">
			Notifications
			<span class="header_settings">
				<a href="./../../ucp.php?i=ucp_notifications&mode=notification_options">Settings</a>
							</span>
		</div>

		<ul>
							<li class="no_notifications">
					You have no notifications
				</li>
								</ul>

		<div class="footer">
			<a href="./../../ucp.php?i=ucp_notifications"><span>See All</span></a>
		</div>
	</div>
</div>
			</li>
					
		</ul>

	<ul id="nav-breadcrumbs" class="linklist navlinks" role="menubar">
						<li class="small-icon icon-home breadcrumbs">
									<span class="crumb" itemtype="http://data-vocabulary.org/Breadcrumb" itemscope=""><a href="./../../index.php" accesskey="h" data-navbar-reference="index" itemprop="url"><span itemprop="title">Board index</span></a></span>
											<span class="crumb" itemtype="http://data-vocabulary.org/Breadcrumb" itemscope=""><a href="/phpbb12/app.php/notes/" itemprop="url"><span itemprop="title">Notes</span></a></span>
												</li>
		
			</ul>

	</div>
</div>
</div></div>	</div>

	
	<a id="start_here" class="anchor"></a>
	<div id="page-body" role="main">
		
						<div id="information" class="rules">
			<div class="inner">
				<strong>You have entered notes with a memory time.</strong><br /><a href="/phpbb12/app.php/notes/?mem_drop=1&mem_time=1465757940">Click here to list this notes.</a><br />(You will not be remembered for these notes again)
			</div>
		</div>
						<div id="phpbb_announcement" class="forabg">
	<div>
				<div>testing v 1.0.4 with aero file after update to 3.1.9</div>
	</div>
	</div>
	<script type="text/javascript">
	// <![CDATA[
		var pss_cont = document.getElementById('page-body');
		pss_cont.className = 'leftsided';
	// ]]>
	</script>

<h2>Notes</h2>

<form action="/phpbb12/app.php/notes/" method="post" id="notes">

<div class="navbar">
	<div class="inner">

	<ul class="linklist">
		<li><select name="search_in" class="selectbox"><option value="note_subject">Subject</option><option value="note_text">Post</option></select>&nbsp;<input type="text" name="search_string" size="30" maxlength="50" class="inputbox autowidth" />&nbsp;<input type="submit" class="button2" value="Search" /></li>
		<li class="rightside"><select name="sort_by" class="selectbox"><option value="note_subject">Subject</option><option value="note_time" selected="selected">Time</option><option value="note_mem">Memory time</option></select>&nbsp;<select name="sort_order" class="selectbox"><option value="ASC" selected="selected">Ascending</option><option value="DESC">Descending</option></select>&nbsp;<input type="submit" class="button2" value="Sort by" /></li>
	</ul>

	</div>
</div>

</form>


<ul class="linklist"><li><label>Notes</label>&bull;&nbsp;5 / 50</li></ul>

 <div class="action-bar bottom">
	<div class="buttons">

		<a href="/phpbb12/app.php/notes/?mode=new_note" class="button icon-button post-icon">New post</a>
	</div>
</div>

		<div class="post bg2">
		<div class="inner">
	
		<div class="postbody">
		
			<h3 class="first">test board GMT me gmt</h3>
			<div class="content"><img class="smilies" src="./../../images/smilies/lol.gif" alt=":lol:" title="lol" /></div>
			<div class="notice"><strong>Memory time: </strong>12 Jun 2016, 18:35</div>
		</div>
	
		<dl class="postprofile">
			<dt>
				<p class="author"> <b>Posted:</b><br />12 Jun 2016, 18:31</p>
	
				<br />
	
				<ul class="post-buttons">
					<li><a href="/phpbb12/app.php/notes/?mode=edit_note&note_id=3" class="button icon-button edit-icon" title="Edit post"><span>Change</span></a></li>
					<li><a href="/phpbb12/app.php/notes/?mode=delete&note_id=3" class="button icon-button delete-icon" title="Delete post"><span>Delete</span></a></li>
				</ul>
		
			</dt>
		</dl>
	
		<div class="back2top"><a href="#wrap" class="top" title="Top">Top</a></div>
	
		</div>
	</div>
		<div class="post bg1">
		<div class="inner">
	
		<div class="postbody">
		
			<h3 >test with board pdt and me pdt</h3>
			<div class="content">testing 1,2,3</div>
			<div class="notice"><strong>Memory time: </strong>12 Jun 2016, 11:40</div>
		</div>
	
		<dl class="postprofile">
			<dt>
				<p class="author"> <b>Posted:</b><br />12 Jun 2016, 18:35</p>
	
				<br />
	
				<ul class="post-buttons">
					<li><a href="/phpbb12/app.php/notes/?mode=edit_note&note_id=5" class="button icon-button edit-icon" title="Edit post"><span>Change</span></a></li>
					<li><a href="/phpbb12/app.php/notes/?mode=delete&note_id=5" class="button icon-button delete-icon" title="Delete post"><span>Delete</span></a></li>
				</ul>
		
			</dt>
		</dl>
	
		<div class="back2top"><a href="#wrap" class="top" title="Top">Top</a></div>
	
		</div>
	</div>
	
<div class="action-bar bottom">
	<div class="buttons">

		<a href="/phpbb12/app.php/notes/?mode=new_note" class="button icon-button post-icon">New post</a>
	</div>
</div>

<ul class="linklist"><li><label>Notes</label>&bull;&nbsp;5 / 50</li></ul>

<br />

				</div>


<div id="page-footer" role="contentinfo">
	<div class="custombg"><div class="customborder">
<div class="navbar" role="navigation">
	<div class="inner">

	<ul id="nav-footer" class="linklist bulletin" role="menubar">
		<li class="small-icon icon-home breadcrumbs">
									<span class="crumb"><a href="./../../index.php" data-navbar-reference="index">Board index</a></span>
					</li>
		
				<li class="rightside">All times are <abbr title="America/Los Angeles">UTC-07:00</abbr></li>
							<li class="small-icon icon-delete-cookies rightside"><a href="./../../ucp.php?mode=delete_cookies" data-ajax="true" data-refresh="true" role="menuitem">Delete all board cookies</a></li>
			<li class="small-icon icon-members rightside" data-last-responsive="true"><a href="./../../memberlist.php" title="View complete list of members" role="menuitem">Members</a></li>						<li class="small-icon icon-team rightside" data-last-responsive="true"><a href="./../../memberlist.php?mode=team" role="menuitem">The team</a></li>			<li class="small-icon icon-contact rightside" data-last-responsive="true">
		<a href="/phpbb12/app.php/contactadmin" role="menuitem">
			<span>Contact us</span>
		</a>
	</li>
			</ul>

	</div>
</div>
</div></div>
	<div class="copyright">
				<a target="_blank" href="https://www.phpbb.com/community/viewtopic.php?f=476&t=2269886">Aero</a> style developed for phpBB<br />
		Powered by <a href="https://www.phpbb.com/">phpBB</a>&reg; Forum Software &copy; phpBB Limited
						<br /><abbr title="SQL time: 0.047s / PHP time: 0.592s">Time: 0.639s</abbr> | <abbr title="Cached: 2">Queries: 10</abbr> | Peak Memory Usage: 9.47 MiB		<br /><strong><a href="./../../adm/index.php?sid=5e4c7b0b3c7f7ad9554b7b294b6f1d32">Administration Control Panel</a></strong>	</div>

	<div id="darkenwrapper" data-ajax-error-title="AJAX error" data-ajax-error-text="Something went wrong when processing your request." data-ajax-error-text-abort="User aborted request." data-ajax-error-text-timeout="Your request timed out; please try again." data-ajax-error-text-parsererror="Something went wrong with the request and the server returned an invalid reply.">
		<div id="darken">&nbsp;</div>
	</div>

	<div id="phpbb_alert" class="phpbb_alert" data-l-err="Error" data-l-timeout-processing-req="Request timed out.">
		<a href="#" class="alert_close"></a>
		<h3 class="alert_title">&nbsp;</h3><p class="alert_text"></p>
	</div>
	<div id="phpbb_confirm" class="phpbb_alert">
		<a href="#" class="alert_close"></a>
		<div class="alert_text"></div>
	</div>
</div>

</div>

<div>
	<a id="bottom" class="anchor" accesskey="z"></a>
	<img src="./../../cron.php?cron_type=cron.task.core.tidy_search" width="1" height="1" alt="cron" /></div>

<script type="text/javascript" src="./../../assets/javascript/jquery.min.js?assets_version=185"></script>
<script type="text/javascript" src="./../../assets/javascript/core.js?assets_version=185"></script>


<script type="text/javascript" src="./../../ext/phpbb/boardannouncements/styles/all/template/js/boardannouncements.js?assets_version=185"></script>

<script type="text/javascript" src="./../../ext/tatiana5/profileSideSwitcher/styles/prosilver/template/profile_side_switcher.js?assets_version=185"></script>

<script type="text/javascript" src="./../../styles/aero/template/forum_fn.js?assets_version=185"></script>

<script type="text/javascript" src="./../../styles/aero/template/ajax.js?assets_version=185"></script>

<script type="text/javascript" src="./../../ext/vse/abbc3/styles/all/template/js/abbc3.min.js?assets_version=185"></script>




</body>
</html>

puchahawa
Beiträge: 16
Registriert: Do 9. Jun 2016, 23:08

Re: Notes v3.0.4

Beitrag von puchahawa » So 12. Jun 2016, 20:17

Had another idea that may give you some insight. :D

I just added a note at 12:09 pdt (-7) and then went into phpmyadmin to look at the notes table in the DB This is the info in the db for that note. The note time is higher than the reminder time. :?:
note 9.PNG
note 9.PNG (9.94 KiB) 2331 mal betrachtet

Benutzeravatar
oxpus
Chief handy-man
Beiträge: 2414
Registriert: Do 13. Dez 2007, 23:06
Wohnort: Irgendwo im I-Net
Kontaktdaten:

Re: Notes v3.0.4

Beitrag von oxpus » So 12. Jun 2016, 22:30

Sorry, I can't find any error.
The latest script release uses strict "UTC" for all timestamps on edit, save and display the notes, even on remind about them.
I can not more test several situations because the result is alltimes the same: Correct timestamps.

Back to your settings:
The board you uses is set on which timezone? You uses GMT -7 in your profile.
Which timezone does your server uses, in particular PHP?

Here and for my tests PHP is set to GMT + 1 (included DST) and my profile uses the same timezone settings.
But the extension sets all used timestamp to "UTC" for PHP, the user profile and the board itself.
And additional a new function to display the reminder time in the notes list does not include any timezone values.
Based on this the all timecodes should alltimes be the same on every situation... :?
Karsten Ude

Kein Support zu unaufgeforderten PN's, Email oder via Messenger!

puchahawa
Beiträge: 16
Registriert: Do 9. Jun 2016, 23:08

Re: Notes v3.0.4

Beitrag von puchahawa » Mo 13. Jun 2016, 18:25

My settings: Board is GMT and i'm GMT -7 My live board settings: Board is GMT -6 and I'm GMT -7

PHP is set to GMT on test and live boards.

I've been doing a bit of digging to see if I could figure out why I was having the post time show as gmt. So I used a program called winmerge that lets me compare files side by side.

in 3.0.4 my post time was correct and the reminder time was off. You made your edits for v3.0.5 and then my the post time went to GMT and the reminder time was correct. :lol:

In comparing the two controller/main.php files you added the 3 lines of code after this
// Init timezone to neutral zone to avoid differences between save, edit and display reminder times

and made this change.

Code: Alles auswählen

$note_date = $this->user->format_date($notes_data[$i]['note_time']);
v3.0.4
to

Code: Alles auswählen

$note_date	= $this->notes_format_date($notes_data[$i]['note_time']);
in v3.0.5

Out of curiosity I changed the $note_date line in v3.0.5 back to the 3.0.4 version and surprise to me the post time and reminder time showed correctly, but then the reminder came up even when it shouldn't. :lol: ie post time 09:30 reminder 10:00 I find the whole thing quite interesting. :)
notes10.PNG
notes10.PNG (19.78 KiB) 2319 mal betrachtet

Benutzeravatar
oxpus
Chief handy-man
Beiträge: 2414
Registriert: Do 13. Dez 2007, 23:06
Wohnort: Irgendwo im I-Net
Kontaktdaten:

Re: Notes v3.0.4

Beitrag von oxpus » Mo 13. Jun 2016, 18:46

On which time the reminder was shown?

Try this:
Open the file ext/oxpus/notes/controller/main.php and remove the lines

Code: Alles auswählen

		// Init timezone to neutral zone to avoid differences between save, edit and display reminder times
		date_default_timezone_set('UTC');
		$this->config['board_timezone'] = 'UTC';
		$this->user->data['user_timezone'] = 'UTC';
Karsten Ude

Kein Support zu unaufgeforderten PN's, Email oder via Messenger!

puchahawa
Beiträge: 16
Registriert: Do 9. Jun 2016, 23:08

Re: Notes v3.0.4

Beitrag von puchahawa » Mo 13. Jun 2016, 19:16

The reminder showed up as soon as I submitted the post.

This is the result after removing the code
notes11.PNG
notes11.PNG (35.4 KiB) 2312 mal betrachtet

Benutzeravatar
oxpus
Chief handy-man
Beiträge: 2414
Registriert: Do 13. Dez 2007, 23:06
Wohnort: Irgendwo im I-Net
Kontaktdaten:

Re: Notes v3.0.4

Beitrag von oxpus » Mo 13. Jun 2016, 20:16

Very courious.
The original 3.0.5 sets all timezones to UTC.
This will be done by the three lines you've now removed for testings.
In addition to this the format of the displayed notes post and remind times are based on the forum default settings expected the timezone from the user.

Again:
I can test and test and find no error...
Karsten Ude

Kein Support zu unaufgeforderten PN's, Email oder via Messenger!

puchahawa
Beiträge: 16
Registriert: Do 9. Jun 2016, 23:08

Re: Notes v3.0.4

Beitrag von puchahawa » Mo 13. Jun 2016, 20:41

I'm not sure what to tell you. :lol: I've reached the limit of my knowledge.

Are we maybe running different versions of php, and that is why the info is being interpreted differently? I"m running php 5.5.12, Server type: MySQL, Server version: 5.6.1 on Apache/2.4.9

Benutzeravatar
oxpus
Chief handy-man
Beiträge: 2414
Registriert: Do 13. Dez 2007, 23:06
Wohnort: Irgendwo im I-Net
Kontaktdaten:

Re: Notes v3.0.4

Beitrag von oxpus » Mo 13. Jun 2016, 21:28

Since PHP 5 the timezone settings are different from PHP 4.
Normaly using date_default_timezone_set('UTC'); will be enough to trim all timezones to UTC.
Why in your case the timezones will not be ignored is the big question.
Karsten Ude

Kein Support zu unaufgeforderten PN's, Email oder via Messenger!

puchahawa
Beiträge: 16
Registriert: Do 9. Jun 2016, 23:08

Re: Notes v3.0.4

Beitrag von puchahawa » Di 14. Jun 2016, 02:17

I haven't a clue. :(

Antworten